Implement std::fmt::Debug for Map manually

[erayerdin]

Closes #138
Self-explanatory

[aleokdev]

Sadly this means that we'll need to update Debug every time a member changes in Map, but it's better than what we had before IMO. Thanks!

[aleokdev]

Didn't see this was a draft -- Are you planning to add anything else?

[erayerdin]

Instead of debug-printing all tilesets and layers, we only debug-print the length of self.tilesets and self.layers.

I don't know if this is a viable approach as it calls len and allocates String with format!, which would be not as performant as desired. On the other hand, we're talking about Debug here, which should/must be only relied upon debug builds, not release builds (only logs maybe).

[erayerdin]

Didn't see this was a draft -- Are you planning to add anything else?

I was checking TileLayer, FiniteTileLayer, InfiniteTileLayer and map_wrapper! macro to see how I could implement Debug for these but it seems they are already done.

[erayerdin]

@aleokdev This seems like it would not require rewriting the whole implementation for Map (this one specifically). This, however, would add extra to compile time as derivative heavily relies on macros.

If you find this viable, I could go down this path. :)

[aleokdev]

It's ok, we'll do it manually - Same thing we have done for Error (we could've used thiserror but chose not to)

[erayerdin]

Well, I'm going to check TileLayer stuff after I wake up. Thank you for your time. :)

[erayerdin]

@aleokdev

I've checked the TileLayer. Apparently, it is an enum with FiniteTileLayer and InfiniteTileLayer, both of which implement Debug manually (well, at least their inner data FiniteTileLayerData and InfiniteTileLayerData do), and they do not seem to include Vecs to their debug-print.

rs-tiled/src/layers/tile/finite.rs

Lines 19 to 26 in f86e079

	impl std::fmt::Debug for FiniteTileLayerData {
	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
	f.debug_struct("FiniteTileLayerData")
	.field("width", &self.width)
	.field("height", &self.height)
	.finish()
	}
	}

rs-tiled/src/layers/tile/infinite.rs

Lines 18 to 22 in f86e079

	impl std::fmt::Debug for InfiniteTileLayerData {
	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
	f.debug_struct("InfiniteTileLayerData").finish()
	}
	}

So, I think it's good to go. Feel free to merge. 🍺

[aleokdev]

Great, thank you!