Allows empty value and sets default value for maxRetries of cloud run…

… job (GoogleCloudPlatform#7425) * send empty value * add client side default * remove defaul_from_api
maphad · Apr 12, 2023 · fbbcad4 · fbbcad4
1 parent 1190de6
commit fbbcad4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/mmv1/products/cloudrunv2/Job.yaml b/mmv1/products/cloudrunv2/Job.yaml
@@ -560,7 +560,8 @@ properties:
             name: "maxRetries"
             description: |-
               Number of retries allowed per Task, before marking this Task failed.
-            default_from_api: true
+            send_empty_value: true
+            default_value: 3
   - !ruby/object:Api::Type::String
     name: "observedGeneration"
     output: true

diff --git a/mmv1/third_party/terraform/tests/resource_cloud_run_v2_job_test.go b/mmv1/third_party/terraform/tests/resource_cloud_run_v2_job_test.go
@@ -157,7 +157,7 @@ resource "google_cloud_run_v2_job" "default" {
         connector = google_vpc_access_connector.connector.id
         egress = "ALL_TRAFFIC"
       }
-      max_retries = 2
+      max_retries = 0
     }
   }