Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #132

Merged
merged 9 commits into from
Oct 3, 2018
Merged

Cleanup #132

merged 9 commits into from
Oct 3, 2018

Conversation

loechel
Copy link
Contributor

@loechel loechel commented Oct 2, 2018

This is a cleanup pull request, so that additional pull requests could add features or improve programming style

@mar10
Copy link
Owner

mar10 commented Oct 3, 2018

Thanks for contributing.
isort is a good thing, however I would prefer the black style (mode 3?), i.e. allow more than one import per line and explode using brackets.
See psf/black#127

@loechel
Copy link
Contributor Author

loechel commented Oct 3, 2018

Sorry, mein Fehler.

I have pushed a correction so that it will use your prefered isort settings.

@mar10 mar10 merged commit dd53ecd into mar10:master Oct 3, 2018
@loechel loechel deleted the cleanup branch October 3, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loechel @mar10