Maximum stack exceed when running on WEB....(runned your example code in web)

[KaushickSArgekar]

The following JSRangeError was thrown building MyApp(dirty):
Invalid argument: Maximum call stack size exceeded

The relevant error-causing widget was
MyApp
lib/main.dart:30
When the exception was thrown, this was the stack
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 829:8 get

[marcglasberg]

Ok, really weird. I haven't tested it on the web, though. Will do that soon as let you know.

[nullrocket]

I'm seeing the same thing. I narrowed it down somewhat, accessing super.hashCode throws the error, just trying to print the value will cause the same exception.

themed/lib/src/themed.dart

Line 476 in ebc26f3

int get hashCode => super.hashCode ^ id.hashCode ^ defaultColor.hashCode;

I tried cutting out much of the Themed class out and narrowing it down more but haven't been able to yet.

Another issue that I am seeing here in the value getter this also throws an error when trying to access it. You can try adding a print statement to see it throw.

themed/lib/src/themed.dart

Line 458 in ebc26f3

Color? result = _currentTheme[this] as Color?;

[nullrocket]

A little more investigation points to extending Color somehow being the issue. If I create a mock Color class and substitute it for Color everything "works" you can access super and this in overridden methods on ColorRef , using the real class throws an error. I think this is probably a bug at the flutter level, but I don't know for sure.

[nullrocket]

Could this be related?
flutter/flutter#43533

[marcglasberg]

@KaushickSArgekar @nullrocket

Could you please tell me if this is fixed in version 2.1.0?

[arthurdelight4]

@marcglasberg - It's working for me (I ran into the same issue). Nice work! I'm really enjoying this library.

[nullrocket]

@marcglasberg
It is working and I did figure out why I couldn't print the this value within the value getter, it doesn't affect the code as intended to be used, and wasn't a mysterious bug :) but I feel kinda dumb about spending so much time looking at it now.

The default toString method on Color relies on value to print its string, accessing it indirectly from within ColorRef's value getter by printing triggered a recursive set of calls to value. I did override toString for ColorRef just to not be hit by something similar if I did some quick print() debugging later on.

  @override
  int get value {
    // trying to print calls Color.toString which throws the maximum stack exceeded error,
    // because Color's default toString method tries to access value which then recursively calls print / value print / value to
    // infinity.
    print(this);
    Color? result = _currentTheme[this] as Color?;
    result ??= _defaultTheme[this] as Color?;

    result ??= defaultColor;
    if (result == null) throw ConstThemeException('Theme color "$id" is not defined.');
    if (_transformColor != null) result = _transformColor!(result);
    return result.value;
  }

Maybe you could add a toString method to the ColorRef class? Right now printing a ColorRef or calling toString is going to tell you that you have a Color(0x..) class and not a ColorRef.

  @override
  String toString() {
    return "ColorRef('$defaultColor', id: '$id' )";
  }

[marcglasberg]

@nullrocket Thanks for the idea. Please see version 2.2.0: Improved ColorRef.toString() and TextStyleRef.toString() methods.