Skip to content

Commit

Permalink
servo: Merge #12374 - Improve performance of HTMLDivElement construct…
Browse files Browse the repository at this point in the history
…or (from jdm:jsup); r=Manishearth

These changes address two sources of performance loss seen while profiling in #12354. #12358 and rust-lang/rust#34727 are still the biggest offenders, however.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't have performance tests and these are only optimizations

Source-Repo: https://github.com/servo/servo
Source-Revision: 01ec8491d3200d6710336da1bb0f4e01b49dc4bc

UltraBlame original commit: 383b98548e4b848e35322e195dff638072fa2da0
  • Loading branch information
marco-c committed Oct 1, 2019
1 parent 0cb903e commit 9eacc8b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions servo/components/script/dom/htmldivelement.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ impl HTMLDivElement {
pub fn new(localName: Atom,
prefix: Option<DOMString>,
document: &Document) -> Root<HTMLDivElement> {
let element = HTMLDivElement::new_inherited(localName, prefix, document);
Node::reflect_node(box element, document, HTMLDivElementBinding::Wrap)
Node::reflect_node(box HTMLDivElement::new_inherited(localName, prefix, document),
document,
HTMLDivElementBinding::Wrap)
}
}

Expand Down
2 changes: 1 addition & 1 deletion servo/components/servo/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion servo/ports/cef/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9eacc8b

Please sign in to comment.