Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support admin events #474

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

zimaldone
Copy link
Contributor

Hi :),
apologies for any mistake in the process.

A very small addition to support also Admin events and not only User events.
I also fixed a couple of tests based on the latest default settings of Keycloak 22.

@zimaldone zimaldone force-pushed the feat/support-admin-events branch 2 times, most recently from 12e671a to c4924ac Compare August 4, 2023 09:32
…lows & test_authentication_configs

test: trying to support old and new Keycloak versions for test_auth_flows & test_authentication_configs

keycloak/keycloak#20497
@zimaldone
Copy link
Contributor Author

Hi @marcospereirampj & @ryshoooo ,
It's definitely not my intention to bother you with PR requests but I'd only like to understand if there's any way to get a feedback and possibly having the code merged.
I'm happily using the library and I'd not like to switch to a crafted/forked version I maintain, but I'd prefer to rely on the well developed code you have here.
Let me know if I can help for any clarification... I think the change I submitted is pretty simple and small.

Cheers and thanks in advance.

Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @zimaldone!

LGTM! :)

@ryshoooo ryshoooo merged commit cd060c9 into marcospereirampj:master Nov 13, 2023
1 of 2 checks passed
NoDataIsAvailable pushed a commit to NoDataIsAvailable/python-keycloak-extended that referenced this pull request Jan 8, 2024
* feat: added support for Admin Events api

* test: fix auth_flow test and authentication_configs based on KC 22 pre-settings

* docs: update readme

* revert: "test: fix auth_flow test and authentication_configs based on KC 22 pre-settings"

This reverts commit 392b71b.

* test: trying to support old and new Keycloak versions for test_auth_flows & test_authentication_configs

test: trying to support old and new Keycloak versions for test_auth_flows & test_authentication_configs

keycloak/keycloak#20497

* chore: revert Update tox.ini

These tools should be coming from the poetry virtual env

---------

Co-authored-by: Simone Ferrigno <[email protected]>
Co-authored-by: Richard Nemeth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants