Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add typing to Keycloak admin connection #496

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

jackylamhk
Copy link
Contributor

No description provided.

@jackylamhk jackylamhk requested a review from krisfremen November 4, 2023 15:01
Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @jackylamhk!

LGTM :)

@ryshoooo ryshoooo merged commit 2a85ec4 into marcospereirampj:master Nov 13, 2023
14 of 19 checks passed
NoDataIsAvailable pushed a commit to NoDataIsAvailable/python-keycloak-extended that referenced this pull request Jan 8, 2024
* fix: Add typing to Keycloak admin connection

* fix: Backwards compatibility for type hinting

* fix: Use typing.Optional over typing.Union
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants