Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace aioredis pkg by redis #1

Merged
merged 2 commits into from
May 9, 2023

Conversation

Themimitoof
Copy link
Contributor

@Themimitoof Themimitoof commented May 9, 2023

In order to improve the compatibility for python 3.11, aioredis is replaced by redis. The package has been deprecated in Feb 21, 2023 since the introduction of aioredis into redis package with the 4.2.0rc1 release.

For more info see:

@Themimitoof Themimitoof force-pushed the replace-aioredis-pkg-by-redis branch from 212fe87 to 04f304f Compare May 9, 2023 15:38
In order to improve the compatibility for python 3.11, aioredis is
replaced by redis. The package has been deprecated in Feb 21, 2023
since the introduction of aioredis into redis package with the
4.2.0rc1 release.

For more info see:

 - redis/redis-py#1899
 - https://github.com/aio-libs/aioredis-py#-aioredis-is-now-in-redis-py-420rc1-
@Themimitoof Themimitoof force-pushed the replace-aioredis-pkg-by-redis branch from 04f304f to 9ff5ccc Compare May 9, 2023 15:44
@mardiros
Copy link
Owner

mardiros commented May 9, 2023

If you want 3.11, maybe you should add the CI to run python 3.11 too ?

@codecov-commenter
Copy link

Codecov Report

Merging #1 (9ff5ccc) into main (02c2cce) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##              main        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          292       292           
=========================================
  Hits           292       292           
Impacted Files Coverage Δ
src/dj_blacksmith/client/_async/middleware.py 100.00% <100.00%> (ø)
src/dj_blacksmith/client/_sync/client.py 100.00% <100.00%> (ø)
src/dj_blacksmith/client/_sync/middleware.py 100.00% <100.00%> (ø)
...c/dj_blacksmith/client/_sync/middleware_factory.py 100.00% <100.00%> (ø)

@mardiros mardiros merged commit 64b3f4d into mardiros:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants