Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot swap skia useValue and runSpring hooks with standard reanimated ones #99

Closed

Conversation

daxaxelrod
Copy link

Need a second pair of eyes here. Got everything to compile but having trouble when testing locally. I git cloned the repo and then used npm link to install it locally in another project as a testing ground (also modified metro, thats project references work just fine).

I keep getting a _measure is undefined error which tells me that the babel worklet plugin is not working. Also when I comment out props.animated in src/LineGraph.tsx to just render the static line component, it throws a couple of react errors which I know shouldnt be happening: Invalid hook call, Hooks can only be called in the body of a function and cannot read property 'useState' of null.

Any ideas? SO and gpt came up dry. How did you test the lib locally @mrousavy

@mrousavy
Copy link
Member

Hey, thanks for your PR!

To test it locally just run the example/ app here.

@daxaxelrod
Copy link
Author

Thanks, not working quite right yet, will do more testing over the weekend

@vovacodes
Copy link

Any luck with fixing the example? Running into this in project too :(

@dsshard
Copy link

dsshard commented Mar 12, 2024

Hello! Are there any updates on this PR?

@gabimoncha
Copy link

@mrousavy this PR is not needed anymore since the migration was done

@daxaxelrod daxaxelrod closed this Mar 12, 2024
@mrousavy
Copy link
Member

yup 👍

@mrousavy
Copy link
Member

released in latest version on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants