fix: raise valueError for pageSize > 200 #3472
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Light2Dark is attempting to deploy a commit to the marimo Team on Vercel. A member of the Team first needs to authorize it. |
for more information, see https://pre-commit.ci
|
|
||
| def validate_page_size(page_size: int) -> None: | ||
| # We will need to support frontend row virtualization beyond this limit | ||
| if page_size > 200: |
There was a problem hiding this comment.
curios if this could be 500 or so? not sure where it starts causing issues
There was a problem hiding this comment.
with 50 cols & 500 rows, it gets a little jittery for me, but it's okay. I'm worried about older browsers / lack of cpu/ram users. The worst thing to do is cause a crash (and it's pretty hard to restart marimo, upon restart it tries to run again).
There was a problem hiding this comment.
thanks for checking. agreed with your conclusion then.
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.14-dev27 |
📝 Summary
Fixes #3407 . This will raise an error for
data_editor,dataframeandtablewhen thepage_sizeconfigured is > 200.🔍 Description of Changes
📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick