Helpers Refactors #2119
Helpers Refactors #2119
Conversation
| return hash; | ||
| memo[normalizedKey] = val; | ||
| return memo; | ||
| }, {}); |
There was a problem hiding this comment.
_NEED... ...TRANSFORM..._ jashkenas/underscore#1901
There was a problem hiding this comment.
@thejameskyle what if they give us an array for the ui?!!
There was a problem hiding this comment.
WHY WOULD THEY DO SUCH A HORRIBLE THING?!
There was a problem hiding this comment.
IDK, but you know what?! I'll submit a test case covering it just to kill your
dream
On Tue, Dec 9, 2014 at 8:16 PM, James Kyle [email protected] wrote:
In src/helpers.js
#2119 (diff)
:var normalizedKey = Marionette.normalizeUIString(key, ui);
- if (normalizedKey !== key) {
hash[normalizedKey] = hash[key];delete hash[key];- }
- });
- return hash;
- memo[normalizedKey] = val;
- return memo;
- }, {});
WHY WOULD THEY DO SUCH A HORRIBLE THING?!
—
Reply to this email directly or view it on GitHub
https://github.com/marionettejs/backbone.marionette/pull/2119/files#r21577973
.
There was a problem hiding this comment.
WE'LL PASS AN ACCUMULATOR!!! AND THEN WHAT ARE YOU GONNA DO GRAEME?!?!
|
WE'RE CURSED!! |
|
:) |
|
6️⃣ 6️⃣ 6️⃣ |
Clone of and resolves #2107