read package path from go.mod if it exists

[rrrkren]

this fixes #29

[markbates]

Thanks! Can we switch it using this https://godoc.org/github.com/rogpeppe/go-internal/modfile#ModulePath instead? should be more resilient. :)

[rrrkren]

haha that's some nice round wheels I reinvented, was actually looking for some built in stuff like this. I'll make the changes :)

[rrrkren]

@markbates what do you think should happen if the go.mod is malformed and the package path cannot be found? Should we return an error or infer it from the current path?

[markbates]

if mods are on:

• go.mod found - read module name
• go.mod not found - error
• go.mod malformed -error

If mods are off:

• infer from path

how's that sound to you?

[rrrkren]

sounds good :) so we check for GO111MODULE env first?

[markbates]

Yep, if it’s on then use mods. That’s the pattern we’re taking everywhere else. We don’t have “auto”. :)

…

-- Mark Bates CTO/Founder

On Oct 24, 2018, 5:09 PM -0400, Eric Ren ***@***.***>, wrote: sounds good :) so we check for GO111MODULE env first? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[rrrkren]

should be working now, using v1.0.0-alpha for go-internal/modfile, only change from 0.0.8 to alpha seems to be changing of name from mod-internal to go-internal.

[markbates]

Thanks! I noticed another issue when trying this that needs to be fixed before I can cut a release.

[markbates]

@rrrkren v1.0.5 should do it! :)