Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing existing options in favor of the renderer #302

Closed
chjj opened this issue Dec 4, 2013 · 4 comments · Fixed by #2936
Closed

Removing existing options in favor of the renderer #302

chjj opened this issue Dec 4, 2013 · 4 comments · Fixed by #2936
Labels
proposal RR - refactor & re-engineer Results in an improvement to developers using Marked, or end-users, or both.

Comments

@chjj
Copy link
Member

chjj commented Dec 4, 2013

We have the opportunity to remove:

  • highlight
  • langPrefix
  • headerPrefix
  • heading IDs

In favor of the new renderer.

The downside to this (at least for 3 of them): lack of backward compatibility, and less convenience for users used to marked. While I did merge the renderer, I'm tentatively reimplementing a few of these options. I think the removal of these features should be discussed in another issue because it is a big decision.

cc @lepture

@lepture
Copy link
Contributor

lepture commented Dec 4, 2013

marked is still on the early stage. It has not released 1.0.0 yet. I think it will be ok for these big changes.

  1. headerPrefix and heading IDs doesn't worth the options (I thought)
  2. block highlight is ok with renderer. however, there is a discussion on async highlight in Feature renderer #301

@jonathanong
Copy link

i'd prefer less features, more extensibility. i'm +1 to removing all those options.

chjj added a commit that referenced this issue Dec 23, 2013
…evert."

This reverts commit f9c90b0.

Revert "Fix test cases. Since we have removed the headerPrefix option. There"

This reverts commit 509b284.
@lepture
Copy link
Contributor

lepture commented Feb 17, 2014

@chjj I am wondering why you revert the changes.

@birendra-ideas2it
Copy link

how to give blockquote regular expression like slack?

ghost pushed a commit to zergeborg/marked that referenced this issue May 13, 2016
ghost pushed a commit to zergeborg/marked that referenced this issue May 13, 2016
…asy to revert."

This reverts commit f9c90b0.

Revert "Fix test cases. Since we have removed the headerPrefix option. There"

This reverts commit 509b284.
@joshbruce joshbruce added the RR - refactor & re-engineer Results in an improvement to developers using Marked, or end-users, or both. label Apr 13, 2018
@UziTech UziTech mentioned this issue May 25, 2018
6 tasks
@UziTech UziTech linked a pull request Sep 1, 2023 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this to Done in vNext Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal RR - refactor & re-engineer Results in an improvement to developers using Marked, or end-users, or both.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants