Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emphasis followed by a punctuation #1383

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Fix emphasis followed by a punctuation #1383

merged 3 commits into from
Dec 5, 2018

Conversation

RomanHotsiy
Copy link
Contributor

@RomanHotsiy RomanHotsiy commented Dec 5, 2018 •
edited by styfle
Loading

Marked version:

0.5.2

Markdown flavor: CommonMark

Description

My previous PR #1351 caused a regression for some emphasis use cases. There is no specific CommonMark test to catch that. @styfle could you suggest me where to put the test for this specific use case so it won't break in the future?

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

UziTech
UziTech reviewed Dec 5, 2018
View reviewed changes
lib/marked.js Outdated Show resolved Hide resolved
UziTech
UziTech requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if all the tests pass

@UziTech @RomanHotsiy
Remove trailing space
1386867 
Co-Authored-By: RomanGotsiy <[email protected]>
@UziTech
Copy link
Member

UziTech commented Dec 5, 2018

@RomanGotsiy you can add a test in https://github.com/markedjs/marked/blob/master/test/specs/marked/marked.json

@RomanHotsiy
Copy link
Contributor Author

@UziTech Added a few extra tests and fixed lint issue.

styfle
styfle approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks!

@styfle styfle changed the title Fix emphasis followed by a punctuation (fixes #1378) Fix emphasis followed by a punctuation Dec 5, 2018
@styfle styfle merged commit f8d556a into markedjs:master Dec 5, 2018
@RomanHotsiy RomanHotsiy mentioned this pull request Dec 6, 2018
Merged
@lpinca lpinca mentioned this pull request Jan 2, 2019
Merged
RomanHotsiy pushed a commit to Redocly/redoc that referenced this pull request Jan 17, 2019
@lpinca @RomanHotsiy
chore: update marked to version 0.6.0 (#768)
02f6e18 
The new release includes markedjs/marked#1383.
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
@moamed-syed moamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivate ManPrivate mentioned this pull request Oct 27, 2024
Open
@tdsnyk tdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankari sri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931 mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25 sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtm Latha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDAN GOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024 Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiya ThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Upender5119 Upender5119 mentioned this pull request Oct 30, 2024
Open
@Suriya0802 Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12 Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007 Magali0007 mentioned this pull request Oct 31, 2024
Open
@sureshrtech1 sureshrtech1 mentioned this pull request Oct 31, 2024
Open
@Praganya03 Praganya03 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349 Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@robertnorrie robertnorrie mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnan sinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manohar krithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55 SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-ra swathi-ra mentioned this pull request Nov 2, 2024
Open
@austinskou austinskou mentioned this pull request Nov 3, 2024
Open
@BD-HUGO BD-HUGO mentioned this pull request Nov 3, 2024
Open
@danielsb74 danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26 selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldev merkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-git joedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-Snyk MimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKo BenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@UziTech UziTech UziTech approved these changes

Assignees
No one assigned
Labels
category: inline elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanHotsiy @UziTech @styfle