Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use latest commit for demo master #1457

Merged
merged 3 commits into from
Apr 6, 2019
Merged

use latest commit for demo master #1457

merged 3 commits into from
Apr 6, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 29, 2019 •
edited by joshbruce
Loading

Description

use @master in demo for master version

https://docs-ikjy0vxvf.now.sh/demo/

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech mentioned this pull request Mar 29, 2019
Closed
@styfle
Copy link
Member

styfle commented Mar 29, 2019

I think the branch is cached by the CDN for a week or so which is maybe why it wasn’t showing the latest.

@UziTech
Copy link
Member Author

UziTech commented Mar 29, 2019

If that is the case than this won't fix the issue. I wonder If I should grab the latest commit hash and use that.

@styfle
Copy link
Member

styfle commented Apr 1, 2019

@UziTech That might work. Another alternative is to add a "bust cache" button since there appears to be an API for that (requires an email).

See the full discussion here: jsdelivr/jsdelivr#18101

@UziTech
Copy link
Member Author

UziTech commented Apr 1, 2019

Using the latest commit hash seems to be the right way to go.

https://docs-qaob045da.now.sh/demo/

@UziTech UziTech requested review from davisjam and joshbruce April 3, 2019 21:47
@UziTech
Copy link
Member Author

UziTech commented Apr 3, 2019 •
edited
Loading

I also fixed a bug when using a regular version

https://docs-ikjy0vxvf.now.sh/demo/

@UziTech UziTech changed the title use @master use latest commit for demo master Apr 3, 2019
@UziTech UziTech added the category: docs Documentation changes label Apr 3, 2019
@joshbruce joshbruce merged commit 69c9e63 into markedjs:master Apr 6, 2019
@UziTech UziTech deleted the demo-master-version branch April 9, 2019 19:51
@styfle styfle mentioned this pull request Apr 15, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 3, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Open
Open
Closed
@moamed-syed moamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivate ManPrivate mentioned this pull request Oct 27, 2024
Open
@tdsnyk tdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankari sri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931 mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25 sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtm Latha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDAN GOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024 Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiya ThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Upender5119 Upender5119 mentioned this pull request Oct 30, 2024
Open
@Suriya0802 Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12 Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007 Magali0007 mentioned this pull request Oct 31, 2024
Open
@sureshrtech1 sureshrtech1 mentioned this pull request Oct 31, 2024
Open
@Praganya03 Praganya03 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349 Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@robertnorrie robertnorrie mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnan sinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manohar krithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55 SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-ra swathi-ra mentioned this pull request Nov 2, 2024
Open
@austinskou austinskou mentioned this pull request Nov 3, 2024
Open
@BD-HUGO BD-HUGO mentioned this pull request Nov 3, 2024
Open
@danielsb74 danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26 selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldev merkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-git joedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-Snyk MimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKo BenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbruce joshbruce joshbruce approved these changes

@styfle styfle styfle approved these changes

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
category: docs Documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UziTech @styfle @joshbruce