Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix commonmark example 353 #1477

Closed
wants to merge 2 commits into from
Closed

fix commonmark example 353 #1477

wants to merge 2 commits into from

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Apr 19, 2019

Marked version: 0.6.2

Markdown flavor: CommonMark

related issue #1474 and PR in Mark Text

Description

Fixed commonMark example 353, in this example, there is a non-break whitespace after *, it should not create a list if a non-break whitespace after *, so I remove this .replace(/\u00a0/g, ' ').

Why not add the replacement to inline lexer?

Because of example 503.

Titles must be separated from the link using a whitespace. Other Unicode whitespace like non-breaking space doesn’t work.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech
Copy link
Member

UziTech commented Apr 19, 2019

Duplicate of #897 and #1398

@UziTech UziTech closed this Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants