Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up downloads by creating parallel download requests. #12

Closed
wants to merge 1 commit into from

Conversation

ericandrewlewis
Copy link

Utilizing multiple processes for wget calls speeds downloads up by about 12x.

Slurping the entire plugins directory took me just over an hour with this change. Your mileagebandwidth may vary.

@iandunn
Copy link

iandunn commented Apr 2, 2015

+1, this worked well for me. Took 91 minutes to grab everything from scratch.

@nylen
Copy link
Collaborator

nylen commented Feb 20, 2017

@ericandrewlewis this worked well for me but it needs better progress reporting and error handling. maybe something like this?

  • create a separate ./download script that downloads a single plugin and reports progress
  • check the result of the main exec - on both OS X and Linux, xargs will exit with a non-zero code if one of its commands fails

@ericandrewlewis
Copy link
Author

👋 @nylen Better progress reporting and error handling would be good. What you suggest makes sense to perhaps parallelize individual download processes to track if one goes bad.

@nylen
Copy link
Collaborator

nylen commented Feb 21, 2017

@ericandrewlewis If you are available to work on it further, I'd be happy to review :)

@ericandrewlewis
Copy link
Author

Sorry I won't be working on this further, thanks for the offer to review though 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants