Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrate): Expose dependent path migration #110

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented Dec 31, 2018

BREAKING CHANGE: rename result properties, default path migrations

Description

This change exposes a way to update dependent paths independently of file renames which is needed for defineComponent file renames (since the entry point should change to the marko file).

Depends on marko-js/migrate-v3-widget#2

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #110 into master will decrease coverage by 0.03%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   41.28%   41.24%   -0.04%     
==========================================
  Files          66       66              
  Lines        1875     1874       -1     
==========================================
- Hits          774      773       -1     
  Misses       1101     1101
Impacted Files Coverage Δ
...rate/src/util/default-migrations/component-file.js 50% <0%> (ø) ⬆️
packages/migrate/src/cli.js 0% <0%> (ø) ⬆️
...kages/migrate/src/util/default-migrations/index.js 100% <100%> (ø) ⬆️
packages/migrate/src/index.js 92.85% <100%> (+1.55%) ⬆️
...igrate/src/util/default-migrations/update-paths.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2336c7e...41ecf6a. Read the comment docs.

BREAKING CHANGE: rename result properties, default path migrations
@DylanPiercey DylanPiercey force-pushed the dependent-path-migration branch from cac93f1 to 41ecf6a Compare January 3, 2019 16:53
@DylanPiercey DylanPiercey merged commit 9000add into master Jan 3, 2019
@mlrawlings mlrawlings deleted the dependent-path-migration branch May 7, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant