Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrate): run migrations serially #112

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

DylanPiercey
Copy link
Contributor

Description

Currently file migrations run in parallel but this breaks down with migrations that require prompts. This can cause multiple prompts to be displayed at once which is confusing.

This PR changes migrations to run on one file at a time.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #112 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   41.24%   41.21%   -0.04%     
==========================================
  Files          66       66              
  Lines        1874     1873       -1     
==========================================
- Hits          773      772       -1     
  Misses       1101     1101
Impacted Files Coverage Δ
packages/migrate/src/index.js 92.68% <100%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9000add...131c91c. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 6449d28 into master Jan 3, 2019
@mlrawlings mlrawlings deleted the migrate-run-serially branch May 7, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant