fix: if directive migration for else tags should not migrate

marko-js · Aug 18, 2023 · 0044e93 · 0044e93
1 parent 22d876e
commit 0044e93
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/chilled-planets-divide.md b/.changeset/chilled-planets-divide.md
@@ -0,0 +1,5 @@
+---
+"@marko/compat-v4": patch
+---
+
+Fix issue where if directive migration was running on valid else tags
diff --git a/packages/compat-v4/src/migrate/if-directive.ts b/packages/compat-v4/src/migrate/if-directive.ts
@@ -21,7 +21,13 @@ export default {
     }
 
     const tag = attr.parentPath as t.NodePath<t.MarkoTag>;
-    if (willMigrateAllAttrs(tag)) return;
+    if (
+      (tag.node.name.type === "StringLiteral" &&
+        tag.node.name.value === "if") ||
+      willMigrateAllAttrs(tag)
+    ) {
+      return;
+    }
 
     diagnosticDeprecate(attr, {
       label: `The "${name}" directive is deprecated. Please use "<${name}>" tag instead. See: https://github.com/marko-js/marko/wiki/Deprecation:-control-flow-attributes`,