fix: if directive on else tag

marko-js · Aug 19, 2023 · 85f920c · 85f920c
1 parent 1c3b9f9
commit 85f920c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changeset/plenty-lobsters-dance.md b/.changeset/plenty-lobsters-dance.md
@@ -0,0 +1,6 @@
+---
+"@marko/compat-v4": patch
+"marko-widgets": patch
+---
+
+Fix issue where the if directive was not removed from an else tag.
diff --git a/packages/compat-v4/src/migrate/if-directive.ts b/packages/compat-v4/src/migrate/if-directive.ts
@@ -18,6 +18,7 @@ export default {
         fix() {
           tag.node.arguments = args;
           tag.node.name = t.stringLiteral("else-if");
+          attr.remove();
         },
       });
       return;
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,6 +18,7 @@ export default { @@
             fix() {
               tag.node.arguments = args;
               tag.node.name = t.stringLiteral("else-if");
+              attr.remove();
             },
           });
           return;
@@ Expand Down @@