Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up names and descriptions of vite examples #24

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Clean up names and descriptions of vite examples #24

merged 1 commit into from
Feb 5, 2022

Conversation

ajcwebdev
Copy link
Contributor

While checking out the Vite examples I noticed that a couple had duplicate names and descriptions in their package.json's or didn't exactly following the same naming convention as the example's directory.

This PR suggests the following to distinguish the different examples:

name description
marko-vite-cloudflare-hackernews-example Hacker News demo with Marko, Vite, and Cloudflare
marko-vite-cloudflare-example Sample app that demonstrates the power of building UI components using Marko, Vite, and Cloudflare
marko-vite-express-example Sample app that demonstrates the power of building UI components using Marko, Vite, and Express
marko-vite-fastify-example Sample app that demonstrates the power of building UI components using Marko, Vite and Fastify
marko-vite-http-example Sample app that demonstrates the power of building UI components using Marko, Vite and an HTTP Server

@DylanPiercey
Copy link
Contributor

Very much appreciate you taking the time @ajcwebdev!

@DylanPiercey DylanPiercey merged commit f992a83 into marko-js:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants