feat: error on empty placeholders

marko-js · Oct 13, 2021 · 6db2af0 · 6db2af0
1 parent 6188917
commit 6db2af0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/src/states/PLACEHOLDER.ts b/src/states/PLACEHOLDER.ts
@@ -28,6 +28,14 @@ export const PLACEHOLDER = Parser.createState({
       var newExpression = this.notifiers.notifyPlaceholder(placeholder);
       placeholder.value = newExpression;
     }
+
+    if (!placeholder.value) {
+      this.notifyError(
+        placeholder.pos,
+        "PLACEHOLDER_EXPRESSION_REQUIRED",
+        "Invalid placeholder, the expression cannot be missing"
+      );
+    }
   },
 
   return(childState, childPart, placeholder) {

diff --git a/test/autotest/placeholder-empty/expected.html b/test/autotest/placeholder-empty/expected.html
@@ -0,0 +1 @@
+error:"Invalid placeholder, the expression cannot be missing" (code: "PLACEHOLDER_EXPRESSION_REQUIRED")
diff --git a/test/autotest/placeholder-empty/input.htmljs b/test/autotest/placeholder-empty/input.htmljs
@@ -0,0 +1 @@
+<${}/>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		error:"Invalid placeholder, the expression cannot be missing" (code: "PLACEHOLDER_EXPRESSION_REQUIRED")