feat: add new parser events and rename 'onTagName' to 'onOpenTagName'. #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of
</div>
being processed in the singleonCloseTag
event it is broken into the following segmentsonCloseTagStart
onCloseTagName
onCloseTagStart
For consistency, the
onTagName
event was renamed toonOpenTagName
and a newonOpenTagStart
even was added which matches the open<
bracket.Note:
onOpenTagStart
,onCloseTagStart
&onCloseTagName
are exclusively called for html mode tags.All of the other events are called for concise tags as well. Eg a concise tag will get
onCloseTagEnd
, which shows where the tags body content stops, but will not get anonCloseTagStart
oronCloseTagName
.Motivation and Context
While working on the language server is was discovered that providing completions for the closing tag could be improved if we were to split up it's events so it could be processed earlier.
Screenshots (if appropriate):
Checklist: