Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parsing type parameters #141

Merged
merged 1 commit into from
Nov 22, 2022
Merged

feat: support parsing type parameters #141

merged 1 commit into from
Nov 22, 2022

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented Nov 22, 2022

Description

Add support for type parameter/argument parsing.

Motivation and Context

This is improves on TypeScript support for the language.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022

🦋 Changeset detected

Latest commit: a453b46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 92.13% // Head: 92.69% // Increases project coverage by +0.55% 🎉

Coverage data is based on head (a453b46) compared to base (9788f6e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   92.13%   92.69%   +0.55%     
==========================================
  Files          26       26              
  Lines         801      835      +34     
  Branches      268      280      +12     
==========================================
+ Hits          738      774      +36     
+ Misses         48       46       -2     
  Partials       15       15              
Impacted Files Coverage Δ
src/states/TAG_NAME.ts 100.00% <ø> (ø)
src/util/constants.ts 100.00% <ø> (ø)
src/states/ATTRIBUTE.ts 94.89% <100.00%> (+0.78%) ⬆️
src/states/OPEN_TAG.ts 91.39% <100.00%> (+2.84%) ⬆️
src/util/util.ts 88.00% <100.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/states/OPEN_TAG.ts Outdated Show resolved Hide resolved
src/states/OPEN_TAG.ts Outdated Show resolved Hide resolved
src/util/constants.ts Outdated Show resolved Hide resolved
src/util/constants.ts Outdated Show resolved Hide resolved
@DylanPiercey DylanPiercey force-pushed the type-params branch 3 times, most recently from 309a8a3 to e979be1 Compare November 22, 2022 16:28
BREAKING CHANGE: onTagParams event renamed to onTagBodyParams
@DylanPiercey DylanPiercey merged commit 81cff30 into main Nov 22, 2022
@DylanPiercey DylanPiercey deleted the type-params branch November 22, 2022 17:28
@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant