Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with escaped placeholder at end of tag #143

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

DylanPiercey
Copy link
Contributor

Fix issue where and extra character was being consumed if an escaped placeholder was at the end of a tag.

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2022

🦋 Changeset detected

Latest commit: 55fedd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 93.16% // Head: 93.16% // No change to project coverage 👍

Coverage data is based on head (55fedd7) compared to base (76d00ee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files          26       26           
  Lines        1272     1272           
  Branches      288      288           
=======================================
  Hits         1185     1185           
  Misses         56       56           
  Partials       31       31           
Impacted Files Coverage Δ
src/states/PLACEHOLDER.ts 97.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 635b97c into main Dec 7, 2022
@DylanPiercey DylanPiercey deleted the fix-escaped-placeholder-at-end-of-tag branch December 7, 2022 21:27
@github-actions github-actions bot mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants