Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with expression continuations containing equals #99

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

DylanPiercey
Copy link
Contributor

Description

Fixes a bug where expression continuations containing equals (eg !=) were not consuming enough text because of unnecessary look ahead/behind.

Also optimize and limits valid equals sign expression regexes.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2022

🦋 Changeset detected

Latest commit: 7e7022a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #99 (7e7022a) into main (41b9e2b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          26       26           
  Lines        1058     1058           
  Branches      251      251           
=======================================
  Hits         1000     1000           
  Misses         38       38           
  Partials       20       20           
Impacted Files Coverage Δ
src/states/EXPRESSION.ts 90.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b9e2b...7e7022a. Read the comment docs.

@DylanPiercey DylanPiercey merged commit b1a3008 into main Apr 30, 2022
@DylanPiercey DylanPiercey deleted the equals-expression-continuations branch April 30, 2022 21:46
@github-actions github-actions bot mentioned this pull request Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant