deprecate <script> with export and template-helpers. fixes #547

marko-js · Jan 25, 2017 · 678d384 · 678d384
1 parent bce3836
commit 678d384
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/taglibs/core/core-transformer.js b/taglibs/core/core-transformer.js
@@ -138,7 +138,7 @@ var coreAttrHandlers = [
                 this.addError('The "marko-init" attribute should only be used on the <script> tag');
                 return;
             }
-            this.context.deprecate('The "marko-init" attribute is deprecated.  Use "template-helpers" instead.');
+            this.context.deprecate('The "marko-init" attribute is deprecated.  Use the static tag instead. See https://github.com/marko-js/marko/issues/547');
             var bodyText = el.bodyText;
             el.noOutput = true;
             this.context.addStaticCode(bodyText);
@@ -152,6 +152,7 @@ var coreAttrHandlers = [
                 this.addError('The "template-helpers" attribute should only be used on the <script> tag');
                 return;
             }
+            this.context.deprecate('The "template-helpers" attribute is deprecated and will be removed in the next release candidate. Use the static tag instead. See https://github.com/marko-js/marko/issues/547');
             var bodyText = el.bodyText;
             el.noOutput = true;
             this.context.addStaticCode(bodyText);

diff --git a/widgets/taglib/TransformHelper/handleRootNodes.js b/widgets/taglib/TransformHelper/handleRootNodes.js
@@ -84,6 +84,8 @@ function handleScriptElement(scriptEl, transformHelper) {
     }
 
     if (hasExport) {
+        transformHelper.context.deprecate('Using <script> with an export to create a single file component will be removed in the next release candidate.  Use class instead. \nSee https://github.com/marko-js/marko/issues/547');
+
         let componentVar;
 
         if (needsComponentVar) {