Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-utils): child template analysis in nested node_modules #1820

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

DylanPiercey
Copy link
Contributor

Description

Currently in the child template analysis code it will in some cases use require.resolve in order to find a node_module that contains a Marko file. This is problematic for nested node_modules since that require.resolve would always be relative to wherever Marko is.

This PR updates this to work similarly to the way the taglib resolves these tags, by first checking if a normal path.resolve can work (if it is a relative path) and falling back to the resolve-from module.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2022

🦋 Changeset detected

Latest commit: 11bac2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/babel-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 0a207fb into main Jun 29, 2022
@DylanPiercey DylanPiercey deleted the cta-nested-node_modules branch June 29, 2022 15:28
@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant