fix(babel-utils): child template analysis in nested node_modules #1820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in the child template analysis code it will in some cases use
require.resolve
in order to find anode_module
that contains a Marko file. This is problematic for nestednode_modules
since thatrequire.resolve
would always be relative to wherever Marko is.This PR updates this to work similarly to the way the taglib resolves these tags, by first checking if a normal
path.resolve
can work (if it is a relative path) and falling back to theresolve-from
module.Checklist: