Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marko Widgets support in v5 compiler #2006

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Marko Widgets support in v5 compiler #2006

merged 6 commits into from
Aug 7, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

This PR brings in some runtime behavior leveraged by the legacy v3/widgets api.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: ba87e84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@marko/translator-default Minor
@marko/babel-utils Minor
@marko/compiler Minor
marko Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 38.61% and project coverage change: -4.06% ⚠️

Comparison is base (4286236) 88.94% compared to head (ba87e84) 84.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
- Coverage   88.94%   84.89%   -4.06%     
==========================================
  Files         212      225      +13     
  Lines       17417    18745    +1328     
==========================================
+ Hits        15492    15914     +422     
- Misses       1925     2831     +906     
Files Changed Coverage Δ
...untime/components/legacy/defineComponent-legacy.js 0.00% <0.00%> (ø)
...runtime/components/legacy/defineRenderer-legacy.js 0.00% <0.00%> (ø)
...c/runtime/components/legacy/defineWidget-legacy.js 0.00% <0.00%> (ø)
...src/runtime/components/legacy/dependencies/html.js 0.00% <0.00%> (ø)
...rc/runtime/components/legacy/dependencies/index.js 0.00% <0.00%> (ø)
...src/runtime/components/legacy/dependencies/vdom.js 0.00% <0.00%> (ø)
...kages/marko/src/runtime/components/legacy/index.js 0.00% <0.00%> (ø)
...ages/marko/src/runtime/components/legacy/jquery.js 0.00% <0.00%> (ø)
...kages/marko/src/runtime/components/legacy/ready.js 0.00% <0.00%> (ø)
...o/src/runtime/components/legacy/renderer-legacy.js 0.00% <0.00%> (ø)
... and 31 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 4bdb32d into main Aug 7, 2023
7 of 9 checks passed
@github-actions github-actions bot mentioned this pull request Aug 4, 2023
@DylanPiercey DylanPiercey deleted the widgets-v5 branch January 8, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant