Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor refactoring and type fixes #2480

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 6b4aafb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (7c7d3d6) to head (6b4aafb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/dom/dom.ts 59.09% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2480      +/-   ##
==========================================
- Coverage   87.10%   87.09%   -0.02%     
==========================================
  Files         351      351              
  Lines       40054    40056       +2     
  Branches     2596     2589       -7     
==========================================
- Hits        34890    34885       -5     
- Misses       5138     5147       +9     
+ Partials       26       24       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 622d328 into main Jan 31, 2025
8 of 10 checks passed
@DylanPiercey DylanPiercey deleted the refactoring-jan31-25 branch January 31, 2025 17:25
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant