Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAGS API: Namespaced tags #2488

Merged
merged 2 commits into from
Feb 4, 2025
Merged

TAGS API: Namespaced tags #2488

merged 2 commits into from
Feb 4, 2025

Conversation

DylanPiercey
Copy link
Contributor

Adds support for namespaced tags (eg those under svg/math).

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: ad19bcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/translator-interop-class-tags Patch
marko Patch
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 95.77465% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (878e689) to head (ad19bcf).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/dom/dom.ts 81.81% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2488   +/-   ##
=======================================
  Coverage   87.12%   87.13%           
=======================================
  Files         351      351           
  Lines       40222    40263   +41     
  Branches     2608     2621   +13     
=======================================
+ Hits        35045    35082   +37     
- Misses       5153     5158    +5     
+ Partials       24       23    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 8a42b58 into main Feb 4, 2025
10 checks passed
@DylanPiercey DylanPiercey deleted the namespaced-tags branch February 4, 2025 17:57
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant