Bug on jQuery Proxy when w-id contains dash/hyphen #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add failing test for jQuery proxy for widget ID that contains dash
Test to ensure getEl() still working
Update regexp to accept more characters for widget ID
1 similar comment
|
Thanks for the fix! I will back port your fix to Marko Widgets v6 and update here when published. |
|
New version of Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug on jQuery Proxy when w-id contains dash/hyphen, see issue #391
Description
Bug on jQuery Proxy when w-id contains dash/hyphen (e.g
w-id="submit-button")Motivation and Context
This PR contains fix for issue #391
Screenshots (if appropriate):
None
Checklist: