Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for async rendering. #958

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Conversation

DylanPiercey
Copy link
Contributor

Description

The current error message is not clear about what actually happened.

Motivation and Context

#942

Checklist:

  • My code follows the code style of this project.
  • I have updated/added documentation affected by my changes.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Dec 22, 2017

Coverage Status

Coverage remained the same at 90.4% when pulling 54d783d on async-render-error into 95d5f55 on master.

@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #958 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #958   +/-   ##
======================================
  Coverage    90.4%   90.4%           
======================================
  Files         309     309           
  Lines       11396   11396           
======================================
  Hits        10302   10302           
  Misses       1094    1094
Impacted Files Coverage Δ
src/runtime/vdom/AsyncVDOMBuilder.js 91% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d5f55...54d783d. Read the comment docs.

@mlrawlings
Copy link
Member

👍

@DylanPiercey DylanPiercey merged commit dea1498 into master Dec 22, 2017
@DylanPiercey DylanPiercey deleted the async-render-error branch December 22, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants