Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use node_module browser-remaps instead of local package.json #20

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

Avoids inline package.json files and instead creates an @internal node_modules folder to use for browser remaps. This has improved support across bundlers.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +8.61% 🎉

Comparison is base (df6e6f1) 85.29% compared to head (9405838) 93.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   85.29%   93.91%   +8.61%     
==========================================
  Files          17        6      -11     
  Lines         340      115     -225     
  Branches       74       22      -52     
==========================================
- Hits          290      108     -182     
+ Misses         26        2      -24     
+ Partials       24        5      -19     
Files Changed Coverage Δ
src/util/stream.ts 93.05% <93.05%> (ø)
src/components/micro-frame-slot/index.marko 100.00% <100.00%> (ø)
src/components/micro-frame/index.marko 100.00% <100.00%> (ø)
src/components/stream-source/index.marko 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 00e60ef into main Aug 8, 2023
@DylanPiercey DylanPiercey deleted the use-node_module-remaps branch August 8, 2023 17:25
Copy link
Contributor

@bill-min bill-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants