Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream source for marko 4 #21

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Conversation

DylanPiercey
Copy link
Contributor

Description

The previous patch in #20 causes a regression in Marko 4 since it switched the component.ts to use export default instead of export =. This PR reverts that change.

This PR also ensures that prettier properly runs against files in the @internal node_modules.

@DylanPiercey DylanPiercey force-pushed the fix-stream-source-for-marko-4 branch from a273181 to 04491af Compare August 8, 2023 20:47
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (00e60ef) 95.65% compared to head (5e8860d) 95.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files           6        6           
  Lines         115      115           
  Branches       23       23           
=======================================
  Hits          110      110           
  Misses          2        2           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 130529e into main Aug 8, 2023
@DylanPiercey DylanPiercey deleted the fix-stream-source-for-marko-4 branch August 8, 2023 21:07
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant