feat: allow slot reorder after first chunk #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 6 6
Lines 163 163
Branches 27 27
=======================================
Hits 156 156
Misses 2 2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows ebay-ads-slot tag to be rendered in-order before first chunk then convert to out-of-order afterwards. In the case that the loading shimmer is sent from the stream (as first chunk), we want the slot to hold the order until shimmer is ready. If the tag is out-of-order, there is always a content shift even if the first chunk is cached and streamed at very beginning.
Motivation and Context
Screenshots (if appropriate):
Checklist: