Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor the way classes are formatted to account for shorthand #16

Closed
wants to merge 1 commit into from

Conversation

LuLaValva
Copy link
Member

Motivation and Context

Description

  • Refactored the way that classes and ids are handled by plugin
  • Decisions made for this PR:
    • Class names are auto-shorthanded when they are string literals which are never dynamic, immediately after the class keyword or in an array.
    • Class lists of length 1 are automatically converted to atoms

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 25, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: LuLaValva / name: Luke LaValva (72bd370)

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 95.32% // Head: 94.96% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (72bd370) compared to base (b14f267).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   95.32%   94.96%   -0.37%     
==========================================
  Files          11       11              
  Lines         364      377      +13     
  Branches      111      116       +5     
==========================================
+ Hits          347      358      +11     
- Misses         12       13       +1     
- Partials        5        6       +1     
Impacted Files Coverage Δ
src/index.ts 94.75% <100.00%> (+0.28%) ⬆️
src/utils/get-original-code.ts 77.77% <0.00%> (-22.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LuLaValva LuLaValva changed the title fix: refactor class handling to handle shorthand effectively fix: refactor the way classes are formatted to account for shorthand Nov 9, 2022
@LuLaValva LuLaValva self-assigned this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixing class attribute with class shorthand results in unexpected output
2 participants