Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strictly numerical arrays were truncated #20

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

LuLaValva
Copy link
Member

Description

This code:

$ const arr = [1, 2, 3];

formatted to this:

$ const arr = [3];

The primary cause of this is that Prettier's printDocToString has side effects that we didn't expect, so we need to give it an individual copy of docs.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@LuLaValva LuLaValva requested a review from DylanPiercey March 10, 2023 02:08
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (1352984) 92.47% compared to head (3d5357c) 92.53%.

❗ Current head 3d5357c differs from pull request most recent head cb5066a. Consider uploading reports for the commit cb5066a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   92.47%   92.53%   +0.06%     
==========================================
  Files          11       11              
  Lines         372      375       +3     
  Branches      113      113              
==========================================
+ Hits          344      347       +3     
  Misses         13       13              
  Partials       15       15              
Impacted Files Coverage Δ
src/index.ts 90.24% <100.00%> (+0.12%) ⬆️
src/utils/with-block-if-needed.ts 100.00% <100.00%> (ø)
src/utils/with-parens-if-needed.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 9927fb0 into marko-js:main Mar 10, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants