Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing comma #39

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Trailing comma #39

merged 1 commit into from
Jun 16, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

Partially improves #38. This comma is now only added when prettier is explicitly configured to do so (previously this was incorrectly following prettiers config).

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8eb2d7a) 90.76% compared to head (92d4d38) 90.76%.

❗ Current head 92d4d38 differs from pull request most recent head 238eed5. Consider uploading reports for the commit 238eed5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files          11       11           
  Lines         455      455           
  Branches      135      135           
=======================================
  Hits          413      413           
  Misses         21       21           
  Partials       21       21           
Impacted Files Coverage Δ
src/index.ts 89.93% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 0c0f507 into main Jun 16, 2023
@DylanPiercey DylanPiercey deleted the trailing-comma branch June 16, 2023 15:33
@github-actions
Copy link

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant