fix: avoid infinite recursion on self reference dep

marko-js · Jan 4, 2022 · ac32fe6 · ac32fe6
1 parent e064f88
commit ac32fe6
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 4 deletions.
diff --git a/...elf-reference-fn/__snapshots__/misc-self-reference/with-default/node.render.expected.html b/...elf-reference-fn/__snapshots__/misc-self-reference/with-default/node.render.expected.html
diff --git a/...self-reference-fn/__snapshots__/misc-self-reference/with-default/web.render.expected.html b/...self-reference-fn/__snapshots__/misc-self-reference/with-default/web.render.expected.html
diff --git a/src/__tests__/fixtures/misc/self-reference-fn/index.test.ts b/src/__tests__/fixtures/misc/self-reference-fn/index.test.ts
@@ -0,0 +1,5 @@
+import fixture from "../../../fixture";
+
+describe("misc self reference", () => {
+  describe("with default", fixture("./templates/self-reference.marko"));
+});
diff --git a/src/__tests__/fixtures/misc/self-reference-fn/templates/self-reference.marko b/src/__tests__/fixtures/misc/self-reference-fn/templates/self-reference.marko
@@ -0,0 +1,3 @@
+<const/fn() {
+  console.log(fn);
+}/>
diff --git a/src/transform/cached-function/transform.ts b/src/transform/cached-function/transform.ts
@@ -6,10 +6,13 @@ import isCoreTag from "../../util/is-core-tag";
 import getAttr from "../../util/get-attr";
 import isApi from "../../util/is-api";
 type DepsVisitorState =
-  | { shallow?: undefined; deps?: Set<string> }
-  | { shallow: true; deps?: true };
+  | { root: t.NodePath; shallow?: undefined; deps?: Set<string> }
+  | { root: t.NodePath; shallow: true; deps?: true };
 
 const depsVisitor = {
+  Function(fn, state) {
+    if (fn === state.root) fn.skip();
+  },
   ReferencedIdentifier: ((identifier, state) => {
     const { name } = identifier.node;
     const binding = identifier.scope.getBinding(name);
@@ -26,7 +29,7 @@ const depsVisitor = {
           // Const tag reflects the default value as dependencies.
           const nestedState: DepsVisitorState = state.shallow
             ? state
-            : { shallow: true };
+            : { root: state.root, shallow: true };
           getAttr(bindingTag, "default")!.traverse(depsVisitor, nestedState);
           isDep = !!nestedState.deps;
         } else {
@@ -60,7 +63,7 @@ export default {
       return;
     }
 
-    const state: DepsVisitorState & { deps?: Set<string> } = {};
+    const state: DepsVisitorState & { deps?: Set<string> } = { root: fn };
     fn.skip();
     fn.traverse(depsVisitor, state);