Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional type parameter to the get tag #51

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

svallory
Copy link
Contributor

Improve get tag type by accepting an optional type parameter that specifies the returned value type.

When no type parameter is provided, the return value type remains unknown

Description

image image

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 6da549c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/tags-api-preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (408f711) to head (cb125b9).

❗ Current head cb125b9 differs from pull request most recent head 6da549c. Consider uploading reports for the commit 6da549c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   77.50%   77.50%           
=======================================
  Files          63       63           
  Lines        1307     1307           
  Branches      341      341           
=======================================
  Hits         1013     1013           
  Misses        259      259           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 87c09f8 into marko-js:main Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants