Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid require for devtools #19

Merged
merged 2 commits into from
Dec 14, 2023
Merged

fix: avoid require for devtools #19

merged 2 commits into from
Dec 14, 2023

Conversation

DylanPiercey
Copy link
Contributor

  • Avoid using require to load devtools, instead rely on export conditions.
  • Ensure ssr internal client exposes ready lookup.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dc87c4) 79.45% compared to head (45eb7e9) 84.05%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   79.45%   84.05%   +4.60%     
==========================================
  Files          12        5       -7     
  Lines         219       69     -150     
  Branches       26        4      -22     
==========================================
- Hits          174       58     -116     
+ Misses         34        6      -28     
+ Partials       11        5       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 06e59ba into main Dec 14, 2023
4 checks passed
@DylanPiercey DylanPiercey deleted the fix-devtools branch December 14, 2023 21:13
Copy link

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant