fix: switch to mutation style for vite config mutations

marko-js · Sep 29, 2022 · bd9a98f · bd9a98f
1 parent 92d047c
commit bd9a98f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/.changeset/warm-guests-carry.md b/.changeset/warm-guests-carry.md
@@ -0,0 +1,5 @@
+---
+"@marko/vite": patch
+---
+
+Switch to purely using the mutation style for update config in the config hook.
diff --git a/src/index.ts b/src/index.ts
@@ -191,6 +191,13 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
           ])
         );
 
+        const optimizeExtensions = (optimizeDeps.extensions ??= []);
+        optimizeExtensions.push(".marko");
+
+        const esbuildOptions = (optimizeDeps.esbuildOptions ??= {});
+        const esbuildPlugins = (esbuildOptions.plugins ??= []);
+        esbuildPlugins.push(esbuildPlugin(compiler, baseConfig));
+
         const ssr = (config.ssr ??= {});
         if (ssr.noExternal !== true) {
           ssr.noExternal = Array.from(
@@ -199,20 +206,6 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
             )
           );
         }
-
-        return {
-          ...config,
-          optimizeDeps: {
-            ...config.optimizeDeps,
-            extensions: [".marko", ...(config.optimizeDeps?.extensions || [])],
-            esbuildOptions: {
-              plugins: [
-                esbuildPlugin(compiler, baseConfig),
-                ...(config.optimizeDeps?.esbuildOptions?.plugins || []),
-              ],
-            },
-          },
-        };
       },
       configureServer(_server) {
         ssrConfig.hot = domConfig.hot = true;