Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relative assets transform #109

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

DylanPiercey
Copy link
Contributor

Description

Brings over the (adapted) native tag relative asset import transform from @marko/run.
This allows you to have code like <img src="./relative-path.png"> be processed with vite.

Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: a1f658a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (430a291) 74.40% compared to head (a1f658a) 75.18%.

Files Patch % Lines
src/relative-assets-transform.ts 85.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   74.40%   75.18%   +0.78%     
==========================================
  Files          10       11       +1     
  Lines         250      270      +20     
  Branches       49       55       +6     
==========================================
+ Hits          186      203      +17     
- Misses         45       46       +1     
- Partials       19       21       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey force-pushed the relative-assets-transform branch from 895c46a to 3dfdf55 Compare November 17, 2023 02:56
@DylanPiercey DylanPiercey force-pushed the relative-assets-transform branch from 3dfdf55 to a1f658a Compare November 17, 2023 03:17
@DylanPiercey DylanPiercey merged commit 257b5d0 into main Nov 17, 2023
8 checks passed
@DylanPiercey DylanPiercey deleted the relative-assets-transform branch November 17, 2023 03:21
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant