feat: Add store option for linked mode builds #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1ea6a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 86.35% // Head: 87.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 86.35% 87.62% +1.26%
==========================================
Files 6 9 +3
Lines 381 412 +31
Branches 98 101 +3
==========================================
+ Hits 329 361 +32
+ Misses 44 43 -1
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
storeoption which allow specifying a method to preserve data between SSR and client builds. Provides two implementations: file system (default) and in memory.Motivation and Context
Various data is produced during the SSR build which is necessary for the client build in linked mode. Today this is written to the file system. This PR decouples this logic into a store interface which can be implemented in any way. By default the store will continue to use the file system but an alternative in memory store is also provided which can improve performance when using Vite programatically.
Screenshots (if appropriate):
Checklist: