-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: fix inline scripts and styles potentially breaking
fix the issue which breaks scripts split in different chunks in the input stream by applying them only after the scripts has been fully visited also fix the same issue for embeded styles, even though there everything works fine it is better to apply all the styles together and avoid potential flashes of unexpected style combinations resolves #1
- Loading branch information
1 parent
51650e1
commit 442cfa3
Showing
8 changed files
with
75 additions
and
4 deletions.
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
src/__tests__/__snapshots__/inline-scripts.expected/step-0.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Embedded App. |
2 changes: 2 additions & 0 deletions
2
src/__tests__/__snapshots__/inline-scripts.expected/step-1.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Embedded App. | ||
<script></script> |
5 changes: 5 additions & 0 deletions
5
src/__tests__/__snapshots__/inline-scripts.expected/step-3.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Embedded App. | ||
<script> | ||
scriptValues = ["a", "b"]; | ||
</script> | ||
After Script. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Embedded App. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Embedded App. <style></style> |
7 changes: 7 additions & 0 deletions
7
src/__tests__/__snapshots__/inline-styles.expected/step-3.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Embedded App. | ||
<style> | ||
h1 { | ||
color: red; | ||
} | ||
</style> | ||
After Styles. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters