Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

feat(custom-tag): added return and tag variables #116

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

LuLaValva
Copy link
Member

Description

  • Added the return tag, and custom variables
  • This is the first pass of the solution, much will likely need to be changed

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 81.15% // Head: 91.19% // Increases project coverage by +10.04% 🎉

Coverage data is based on head (4603db3) compared to base (7a3fcb3).
Patch coverage: 90.35% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #116       +/-   ##
===========================================
+ Coverage   81.15%   91.19%   +10.04%     
===========================================
  Files          86       86               
  Lines        9645     9770      +125     
  Branches     1236     1194       -42     
===========================================
+ Hits         7827     8910     +1083     
+ Misses       1805      845      -960     
- Partials       13       15        +2     
Impacted Files Coverage Δ
packages/translator/src/core/return.ts 78.00% <78.00%> (ø)
packages/runtime/src/common/types.ts 100.00% <100.00%> (ø)
packages/runtime/src/dom/index.ts 98.30% <100.00%> (+0.05%) ⬆️
packages/runtime/src/dom/signals.ts 95.07% <100.00%> (+1.83%) ⬆️
packages/translator/src/core/const.ts 81.25% <100.00%> (+0.60%) ⬆️
packages/translator/src/core/index.ts 100.00% <100.00%> (ø)
packages/translator/src/util/signals.ts 98.48% <100.00%> (+51.56%) ⬆️
packages/translator/src/visitors/program/html.ts 100.00% <100.00%> (ø)
packages/translator/src/visitors/tag/custom-tag.ts 97.04% <100.00%> (+0.40%) ⬆️
packages/runtime/src/dom/hydrate.ts 94.64% <0.00%> (+0.59%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mlrawlings mlrawlings merged commit 86e1c04 into main Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Tag Variables & Return Tag
2 participants