This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
Fix connected sets for Bayesian MSMs #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These sets were not computed on the same count matrix as the one used to compute the active set. This had lead to differences between the largest connected set and the shape of P and pi. When the ergodic cutoff kicked out low populated states in during count matrix estimation, the connected sets were estimated on a wrong measure, because it used the full count matrix instead of the truncated one.
thempel
approved these changes
Jul 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sets were not computed on the same count matrix as the one used to compute the active set.
This had lead to differences between the largest connected set and
the shape of P and pi. When the ergodic cutoff kicked out low populated
states in during count matrix estimation, the connected sets were estimated
on a wrong measure, because it used the full count matrix instead of the truncated one.