Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Update types.py #1503

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Update types.py #1503

merged 3 commits into from
Jul 20, 2021

Conversation

sroet
Copy link
Contributor

@sroet sroet commented Jul 19, 2021

A test for a downstream project is showing the following DeprecationWarning:

/home/sroet/miniconda3/envs/python3/lib/python3.9/site-packages/pyemma/util/types.py:143: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    return isinstance(I, collections.Iterable)

This fixes that Deprectation warning

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • [NA] Make sure to include one or more tests for your change
  • Add yourself to AUTHORS
  • Add a new entry to the doc/source/CHANGELOG (choose any open position to avoid merge conflicts with other PRs).
    Decide whether your change is a fix or a new feature.

@sroet
Copy link
Contributor Author

sroet commented Jul 19, 2021

Appveyor build seem to fail on Conda stuff:

Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... failed
ERROR conda.core.link:_execute(502): An error occurred while installing package 'conda-forge::tqdm-4.61.2-pyhd8ed1ab_1'.
CondaError: Cannot link a source that does not exist. C:\Miniconda36-x64\Scripts\conda.exe
Running `conda clean --packages` may resolve your problem.
Attempting to roll back.
Rolling back transaction: ...working... done
CondaError: Cannot link a source that does not exist. C:\Miniconda36-x64\Scripts\conda.exe
Running `conda clean --packages` may resolve your problem.
Command exited with code 1
$wc = New-Object 'System.Net.WebClient';
$wc.UploadFile("https://ci.appveyor.com/api/testresults/xunit/$($env:APPVEYOR_JOB_ID)", "C:/Users/appveyor/reports/junit.xml")
Exception calling "UploadFile" with "2" argument(s): "An exception occurred during a WebClient request."
At line:2 char:65
+ ... /ci.appveyor.com/api/testresults/xunit/$($env:APPVEYOR_JOB_ID)", "C:/ ...
+                                              ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : WebException
 
Command executed with exception: Exception calling "UploadFile" with "2" argument(s): "An exception occurred during a WebClient request."

@clonker
Copy link
Member

clonker commented Jul 19, 2021

Hi @sroet thank you very much for your contribution! I am currently moving CI services to Azure pipelines so once PR #1505 is through you can try again to run the suite. 🙂

@clonker
Copy link
Member

clonker commented Jul 20, 2021

PR is merged so you can rebase your changeset.

@sroet
Copy link
Contributor Author

sroet commented Jul 20, 2021

PR is merged so you can rebase your changeset.

rebased with a force push

Copy link
Member

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will merge as soon as CI has run through.

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #1503 (9ea8c4d) into devel (d6eba9d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1503      +/-   ##
==========================================
- Coverage   92.03%   92.02%   -0.02%     
==========================================
  Files         229      229              
  Lines       26804    26804              
==========================================
- Hits        24670    24667       -3     
- Misses       2134     2137       +3     
Impacted Files Coverage Δ
pyemma/util/types.py 68.62% <100.00%> (ø)
pyemma/coordinates/data/util/traj_info_backends.py 91.92% <0.00%> (-1.80%) ⬇️
pyemma/_ext/sklearn/base.py 62.87% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6eba9d...9ea8c4d. Read the comment docs.

@clonker clonker merged commit 9739284 into markovmodel:devel Jul 20, 2021
@sroet sroet deleted the patch-1 branch July 20, 2021 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants